Invalid constant name "application" (invalid-name)

[craiga]

pylint_django complains about Django-generated code:

$ django-admin startproject testproj
$ cd testproj
$ pylint --load-plugins pylint_django testproj
No config file found, using default configuration
************* Module testproj.wsgi
C: 16, 0: Invalid constant name "application" (invalid-name)
…

Using: pylint==1.5.6 and pylint-django==0.7.2.

[jasjuang]

Ran into the same problem. Would be great to see this fixed.

[sieira]

+1

[cactail]

Same problem here. Should I ignore the wsgi.py module?

[bittner]

@cactail

As an alternative to disabling the message or ignoring the whole module, using PyLint's --good-names may be a soft enough option:

$ pylint testproj --load-plugins=pylint_django --good-names=application

As usual, those options can also go into a PyLint configuration file to save typing on the command line:

# FILE: pylintrc  or .pylintrc
load-plugins = pylint_django
good-names = application

@carlio

Where would code to ignore "application" (invalid-name) have to go? augmentations looks like the right place, but it's really not all that obvious what to do. Can you give a hint?

As invalid-name corresponds to C0103, the code would probably have to look similar to the media attributes suppression. Does checking whether application then is an attribute of a module named wsgi make sense?

[bittner]

Any hint to start tackling this issue would be greatly appreciated, @carlio!

Who will take care of maintenance and PRs in future, now that this repo is under the PyCQA umbrella?

[atodorov]

@bittner @colinhowe and myself joined this project as new maintainers just before it moved under PyCQA. I have closed a few issues yesterday and will continue to work on the rest during the next few weeks.

Not sure what my permissions on the repo are after the move but I will gladly continue maintaining this package.

[carlio]

@bittner @atodorov @colinhowe I'll will certainly be helping and now others are too and hopefully with the new moves it will help keep things going :-) It was a bit staid when I was on it alone so I think this is a good move for users and the lib itself.

[bittner]

Okay, thanks!

Remains the first part of the question to be answered: 😏

Any hint to start tackling this issue would be greatly appreciated, @carlio!

[atodorov]

@bittner the easiest way will be to append 'application' to good_names in pylint_django/plugin.py.

The other will be to add an augmentation which silences the invalid-name message from pylint when visiting a AssignName node, which is named "application" and lives inside the "wsgi" module. ATM I don't know if astroid nodes carry module information with them but quick look tells me no.