Cleaning #207
Merged
Cleaning #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
reviewed
Nov 29, 2018
pylint_django/compat.py
Outdated
| @@ -28,16 +29,3 @@ | |||
| # if not available, will be handled by the django_installed checker | |||
| django_version = (1, 5) | |||
There was a problem hiding this comment.
FIY we're Python 3 only ATM so no need to worry about older Django versions, right ?
There was a problem hiding this comment.
The hardcoded 1.5 was really just to try to avoid complete failures due to not being able to import django at all. I will look through this but I think this method can go completely too.
atodorov
approved these changes
Nov 29, 2018
this is not really used and elsewhere we do: from django import VERSION as django_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atodorov placholder PR to clean up the old compat code that is no longer necessary