Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of base python in pep517 builds breaks eg pydantic-core #2133

Closed
2 tasks
dimbleby opened this issue Jul 1, 2024 · 1 comment · Fixed by #2134
Closed
2 tasks

use of base python in pep517 builds breaks eg pydantic-core #2133

dimbleby opened this issue Jul 1, 2024 · 1 comment · Fixed by #2134
Labels
bug Something isn't working sdist Source distribution

Comments

@dimbleby
Copy link

dimbleby commented Jul 1, 2024

Bug Description

#2094 arranged that maturin passes around the base python interpreter, rather than the python interpreter associated with the isolated build environment.

but then build-requirements declared in projects are not available to that interpreter

this causes the failure reported in pydantic/pydantic-core#1352, per pydantic/pydantic-core#1352 (comment)

Your maturin version (maturin --version)

1.6.0

Your Python version (python -V)

3.12

Your pip version (pip -V)

n/a

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  • git clone [email protected]:pydantic/pydantic-core.git
    • eg v2.20.0 will work as a tag to reproduce the issue
  • create and activate virtual env eg uv venv -p python3.12 ~/.virtualenvs/foo && workon foo
  • install build eg uv pip install build
  • python -m build
@dimbleby dimbleby added the bug Something isn't working label Jul 1, 2024
@dimbleby
Copy link
Author

dimbleby commented Jul 1, 2024

fyi @messense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdist Source distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants