Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install using maturin pep517 backend fails unless manylinux is off #483

Closed
davidhewitt opened this issue Apr 2, 2021 · 2 comments
Closed

Comments

@davidhewitt
Copy link
Member

davidhewitt commented Apr 2, 2021

Discovered while testing PyO3/pyo3#1537

(Only relevant to 0.10 beta builds.)

If I use maturin as the build-backend in pyproject.toml, unless I set manylinux = "off" then pip install <my_project> will fail on almost all users' machines, because most of them will not be running a manylinux-compatible set of libs.

I realise that when building the wheel it's important to check for manylinux compliance when uploading to pypi. However it feels like maturin users will be more or less required to set manylinux = "off" to make their package locally installable with pip.

I'm not sure what the right solution is, just reporting this as it felt like a papercut to me.

@konstin
Copy link
Member

konstin commented Apr 2, 2021

That's definitely a problem, and it should have now been fixed by #461

@davidhewitt
Copy link
Member Author

Thanks very much, can confirm it has indeed fixed it! Nice one 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants