Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-initialize to become opt-in on PyO3 0.14 #1354

Closed
davidhewitt opened this issue Jan 2, 2021 · 0 comments · Fixed by #1443
Closed

auto-initialize to become opt-in on PyO3 0.14 #1354

davidhewitt opened this issue Jan 2, 2021 · 0 comments · Fixed by #1443
Milestone

Comments

@davidhewitt
Copy link
Member

davidhewitt commented Jan 2, 2021

PR #1347 added the auto-initialize feature.

For compatibility in the 0.13 release series, this feature had to be enabled by default (where this behaviour already exists).

In addition, the compile_error error message where this feature is enabled for PyPy and statically-linked Python interpreters had to be supressed for feature = "extension-module" cases, to avoid breaking builds.

In PyO3 0.14 we should:

  • remove the auto-initialize feature from default-features. (and update the guide)
  • change the compile_error message in gil.rs to show always (not just for not(feature = "extension-module")).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant