Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails when using PyO3's multiple-pymethods feature #287

Closed
prehner opened this issue Mar 8, 2022 · 2 comments · Fixed by #288
Closed

Compilation fails when using PyO3's multiple-pymethods feature #287

prehner opened this issue Mar 8, 2022 · 2 comments · Fixed by #288
Labels

Comments

@prehner
Copy link

prehner commented Mar 8, 2022

The current version of numpy (0.16.0) does not compile any more if the multiple-pymethods feature of PyO3 is active.

Running

cargo build --release --features "pyo3/multiple-pymethods"

results in

error[E0046]: not all trait items implemented, missing: `Inventory`
  --> src/slice_container.rs:94:1
   |
94 | impl PyClassImpl for PySliceContainer {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `Inventory` in implementation
   |
   = help: implement the missing item: `type Inventory = Type;`
@davidhewitt
Copy link
Member

See also PyO3/pyo3#2210 - would welcome your opinion as an active user of this feature.

@adamreichold
Copy link
Member

0.16.1 should be available on crates.io now containing the fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants