-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early stopping when validation is disabled #1235
Conversation
@jeremyjordan @neggert I think you guys worked on callbacks and early stopping. Is it ok to do this change here? Basically what we want (according to @williamFalcon) is that early stopping will work on the training metrics if no validation loop is defined (or it is disabled). |
@awaelchli yeah i think that looks fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for looking at it already. I added a test and properly documented the behaviour. Could you review it again? |
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
======================================
Coverage 92% 92%
======================================
Files 62 62
Lines 3181 3181
======================================
+ Hits 2923 2924 +1
+ Misses 258 257 -1 |
Great job! =) |
* early stop fallback to train epoch * added test * fix imports * update docs * update changelog * fix typo
Before submitting
What does this PR do?
Fixes #1201
(right now it's just just a check that the proposed fix by @Dunrar passes the unit tests).PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃