-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed dependency on pandas, instead use generic csv #736
Removed dependency on pandas, instead use generic csv #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, Thx, just some adjustments needed + rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just waiting for the tests pass...
seems like an issue with CSV paths, @SkafteNicki can you run the tests locally, |
By accident I had hard coded a path variable, which worked for me locally. It should be fixed now. |
@SkafteNicki amazing! |
Before submitting
What does this PR do?
Fixes #693
Completely new contributor to this awesome library. Took a stab at this, removing the dependency on pandas since it was only used in 4 files:
pl_examples
folder with the old and new formatting:PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
YES!