Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export UrlClass #65

Open
dachia opened this issue Nov 22, 2023 · 2 comments
Open

Export UrlClass #65

dachia opened this issue Nov 22, 2023 · 2 comments

Comments

@dachia
Copy link

dachia commented Nov 22, 2023

Hi, @Pythe1337N

Thank you for this library.

There's an obvious use case to use custom requests, and IMHO it would make sense to export UrlClass for that purpose. I am using UrlClass, because you, as a maintainer, know better which URLs are possible. As an example, I had no idea of the GC_API URL until I looked at the source code.

Right now I am importing UrlClass directly like this
import gcUrl from 'garmin-connect/dist/garmin/UrlClass.js';
which is very flaky.

Thank you for all your time and effort!

P.S. If you would prefer it, I can create PR for this

@gregegan
Copy link
Contributor

@dachia - you can access these via GCClient

ie: GCClient.url.BASE_URL

@gregegan
Copy link
Contributor

Mark as resolved @Pythe1337N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants