Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional untyped/type parameters to getActivities method #66

Open
dachia opened this issue Nov 22, 2023 · 2 comments
Open

Add optional untyped/type parameters to getActivities method #66

dachia opened this issue Nov 22, 2023 · 2 comments

Comments

@dachia
Copy link

dachia commented Nov 22, 2023

Hi, @Pythe1337N

underlying getActivities API can support multiple filters, besides offset or limit. For example, very useful parameters are startDate and endDate, activityType.

I propose that, if possible and make sense, add an optional hashmap parameter to the getActivities call and insert those into request params.

Thank you for all your time and effort!

P.S. If you would prefer it, I can create PR for this

@gregegan
Copy link
Contributor

This makes sense to me, can you put up a PR for this @dachia?

@dachia where are you able to find the docs of all the filters that are supported by each endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants