Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Builders to take advantage 4.2 covariance #81

Closed
Pyxus opened this issue Jan 26, 2024 · 1 comment
Closed

Rewrite Builders to take advantage 4.2 covariance #81

Pyxus opened this issue Jan 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Pyxus
Copy link
Owner

Pyxus commented Jan 26, 2024

To make the builders more pleasant to work I would rewrite the builder per class despite each builder otherwise having identical functionality. This is because it was the only way to get autocomplete support for the methods unique to each builder. However, with the new return type covariance included in Godot 4.2 I can now remedy this. The downside is Fray will only support 4.2+ now, However I believe this is fine given the pending re-release.

@Pyxus Pyxus added the enhancement New feature or request label Jan 26, 2024
@Pyxus
Copy link
Owner Author

Pyxus commented Jan 26, 2024

Solved by 2fdf608

@Pyxus Pyxus closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant