Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add quick links if diff has more than 1 file change #84

Open
aik opened this issue Nov 15, 2016 · 3 comments
Open

Feature request: add quick links if diff has more than 1 file change #84

aik opened this issue Nov 15, 2016 · 3 comments

Comments

@aik
Copy link

aik commented Nov 15, 2016

$subj

@Qeole
Copy link
Owner

Qeole commented Nov 16, 2016

Hi, and thanks! Am I correct to suppose that by adding “quick links”, you mean adding a list of modified files (with the links) similar to a ToC at the beginning of the diff for quick jumps? Or did I miss the point?

@aik
Copy link
Author

aik commented Nov 17, 2016

No, you got it right :) A patch may change 25 files, and I only care about few - so I need a way to jump quickly to these files. I could think of a drop-down list of files where all the addon controls are ooooor replace file names in the index with clickable links (I do not know if it is doable though). By "index" I mean this:

include/sysemu/numa.h | 2 +-
include/sysemu/sysemu.h | 7 -------
numa.c | 19 ++++++++++++-------
vl.c | 5 -----
4 files changed, 13 insertions(+), 20 deletions(-)

@Qeole
Copy link
Owner

Qeole commented Nov 17, 2016

Ok, understood. I like (more) the second idea, adding links to the names in the index.
I became maintainer of this add-on some months ago, but I don't know enough of the code yet to tell how easy that would be to implement.

Also, adding features here is not at the top of my todo-list, so do not expect me to do it really soon, I'll see when I have some spare time (or if anyone else wants to give it a try, don't hesitate).

Meanwhile, thanks for the idea and for using the add-on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants