Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scroll issue in IE #275

Merged
merged 2 commits into from
Oct 11, 2017
Merged

fix scroll issue in IE #275

merged 2 commits into from
Oct 11, 2017

Conversation

laysent
Copy link
Contributor

@laysent laysent commented Oct 11, 2017

Docify is not able to scroll to anchor in IE. This issue can be reproduced by using IE (for example IE 11) to visit docsify website and clicking link on sidebar.

According to MDN, property scrollY is not available in IE. Meanwhile, pageYOffset property is an alias for the scrollY property and is available in IE 9+ and all other browsers (details here).

The other commit will add extra meta tag in html files, to force IE browsers to render page using latest version of IE available. Otherwise, it might use IE 7 to render, which will cause issues.

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@QingWei-Li QingWei-Li merged commit 3e94cb6 into docsifyjs:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants