Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in runtime following implementation of Session in provider #969

Closed
4 of 5 tasks
merav-aharoni opened this issue Jul 23, 2023 · 5 comments · Fixed by #1053
Closed
4 of 5 tasks

Changes in runtime following implementation of Session in provider #969

merav-aharoni opened this issue Jul 23, 2023 · 5 comments · Fixed by #1053
Assignees
Labels
enhancement New feature or request technical debt
Milestone

Comments

@merav-aharoni
Copy link
Contributor

merav-aharoni commented Jul 23, 2023

What is the expected feature or enhancement?
In Qiskit/qiskit-ibm-provider#675, we are supporting Session in qiskit-ibm-provider.
I am opening this issue to keep track of changes that should be done here after the above PR is complete.

  • Remove utils/converters.py and import that from qiskit-ibm-provider.
  • Can class Session be united between the two repos?
  • Can api/rest/rutime_session.py be united between the two repos?
  • Consider removing Session._circuits_map if not used
  • Fix example in session.py documentation. circ is not defined.

Acceptance criteria

@jyu00
Copy link
Collaborator

jyu00 commented Aug 21, 2023

Addition code that can probably be united:

  • ibm_backend.py
  • hub_group_project.py
  • exception.py
  • constants.py
  • account management
  • job
  • a bunch of code in utils, like json.py, runner_result.py, etc

@merav-aharoni
Copy link
Contributor Author

Session here cannot be united with that of qiskit-ibm-provider because here is has a QiskitRuntimeService member. However, I think we could inherit here from Session in provider. This would require changing one of the Session names. @kt474 , @jyu00 - let me know if you think this is worthwhile.

@merav-aharoni
Copy link
Contributor Author

I am moving this list to #1028, because these duplications are not related to the implementation of Session in the provider, and uniting these files is not trivial.

@kt474
Copy link
Member

kt474 commented Sep 7, 2023

Session here cannot be united with that of qiskit-ibm-provider because here is has a QiskitRuntimeService member. However, I think we could inherit here from Session in provider. This would require changing one of the Session names. @kt474 , @jyu00 - let me know if you think this is worthwhile.

We can focus on the other parts of this issue for now, changing one of the Session names would complicate things for users.

@kt474
Copy link
Member

kt474 commented Sep 7, 2023

will track the remaining code duplication/consolidation in #1028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants