Remove workers from ray-cluster #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # charts/qiskit-serverless/charts/gateway/templates/rayclustertemplate.yaml
Tansito
changed the title
|
@akihikokuroda reviewing the configuration of the cluster I had a question related with the values:
Would has sense to only do |
It means that it doesn't create the self-signed certificates. I think that's OK. If the cluster doesn't have the cert manager, the TLS may not be needed. |
|
And with Istio I suppose that they are not needed either, aren't they? |
|
@Tansito That's right. |
psschwei
approved these changes
Jul 31, 2024
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to some problems in the current configuration that we have in the cluster we cannot support workers right now. After some tests I could confirm that we can support the same features that we are supporting right now increasing the size of the head node.
So, this PR modifies the ray-cluster template removing the workers from the configuration.