Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework handling of instruction durations in preset pass managers #10449

Closed
mtreinish opened this issue Jul 19, 2023 · 0 comments · Fixed by #12183
Closed

Rework handling of instruction durations in preset pass managers #10449

mtreinish opened this issue Jul 19, 2023 · 0 comments · Fixed by #12183
Assignees
Milestone

Comments

@mtreinish
Copy link
Member

mtreinish commented Jul 19, 2023

In #10291 we added a hack to serialize the execution of transpile() with multiple circuits if a custom InstructionDurations or dt was specified as arguments to transpile(). This was to workaround the behavior that the InstructionDurations object constructed by transpile() was a function of the input circuit to factor in the durations of custom calibrations in the circuit to that custom InstructionDurations object. A better long term fix is to revise the passes using InstructionDurations to do the custom circuit calibrations handling inline as needed instead of doing it in transpile().

I do wonder if an implementation of #9256 would alleviate some of those concerns. Because then the passes will only get a target and we're not using InstructionDurations anywhere (except for the plugin interface). But I'll convert this comment into an issue for 0.26 and we can track it there.

Originally posted by @mtreinish in #10291 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants