Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework heirarchy of CircuitInstruction and PackedInstruction #12622

Closed
mtreinish opened this issue Jun 20, 2024 · 0 comments · Fixed by #12730
Closed

Rework heirarchy of CircuitInstruction and PackedInstruction #12622

mtreinish opened this issue Jun 20, 2024 · 0 comments · Fixed by #12730
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library priority: high Rust This PR or issue is related to Rust code in the repository type: feature request New feature or request
Milestone

Comments

@mtreinish
Copy link
Member

What should we add?

Since #10827 we had a two level hierarchy for instructions in a circuit. There was CircuitInstruction which was a python space representation and PackedInstruction which was a rust space representation with a compressed qubit representation. At that point in time this was fine because we never were accessing any data in the circuit via rust and we were only using rust to store a compressed form at rest. However, since #12459 merged this has gotten a bit more muddled because we have frequent use of circuit data via rust. This has led the original abstractions to not holding up as well because the packed instruction is not as compact as it could be and the we're using the python space representation from rust. We should add a new middle representation for a rust native "unpacked instruction".

@mtreinish mtreinish added type: feature request New feature or request priority: high Rust This PR or issue is related to Rust code in the repository mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Jun 20, 2024
@mtreinish mtreinish added this to the 1.2.0 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library priority: high Rust This PR or issue is related to Rust code in the repository type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant