Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.7.x generate broken var(--white) #60

Closed
iurisilvio opened this issue Nov 26, 2021 · 3 comments
Closed

Version 1.7.x generate broken var(--white) #60

iurisilvio opened this issue Nov 26, 2021 · 3 comments

Comments

@iurisilvio
Copy link

After today upgrade, my nuxt app replaced var(--white) with var(#fff), which generated broken CSS.

I have

:root {
    --white: #ffffff;
}

Version 1.7.0 works fine, versions 1.7.1 and 1.7.4 are broken. I didn't tested with 1.7.2 and 1.7.3, but I expect the same issue there.

@iurisilvio iurisilvio changed the title Version 1.7.x generate broken var(--abc) Version 1.7.x generate broken var(--white) Nov 26, 2021
@Qix-
Copy link
Owner

Qix- commented Nov 26, 2021

This seems like a bug in Nuxt. We don't check for var(). Please open an issue with them as they might be mis-using this library.

@Qix- Qix- closed this as completed Nov 26, 2021
@iurisilvio
Copy link
Author

The same project works with version 1.7.0 and fails with 1.7.1, it's definitely related with color-string.

@Qix-
Copy link
Owner

Qix- commented Nov 26, 2021

That's not a given. You shouldn't be passing in var() to this library, so clearly you're mis-using it. If you were relying on a bug (in this case, unspecified input) prior to the bugfixes going out, that's not my problem. Sorry.

If you're using a framework that wraps this library, please open an issue with the framework maintainers. Nothing I've changed here today breaks the specified API of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants