Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus issues in Lumino menu bar #225

Open
5 of 8 tasks
gabalafou opened this issue Jun 29, 2023 · 1 comment
Open
5 of 8 tasks

Fix focus issues in Lumino menu bar #225

gabalafou opened this issue Jun 29, 2023 · 1 comment
Assignees
Labels
area: codebase 💻 Item related to codebase and software development work area: WCAG compliance ♿️ This item related to WCAG standards and their compliance

Comments

@gabalafou
Copy link
Contributor

gabalafou commented Jun 29, 2023

Summary

A cursor is to a mouse user what focus is to a keyboard user.

The Lumino menu bar has a number of focus anti-patterns, which makes it very hard to use if you are a blind or low-vision keyboard user, such as: moving focus on mouse over (you generally should not shift browser focus unless a key has been pressed or the mouse has been clicked), not moving browser focus as the user navigates the menu with a keyboard, and others.

Acceptance Criteria

  • The JupyterLab focus visible test passes
  • Focus does not move when user moves mouse over menu bar item
  • Focus does move when user uses keyboard to select item in menu bar
  • Pressing escape does not lose focus to the document body

Tasks to complete

  • Watch PhosphorJS mentor sessions to better understand the code architecture and philosophy of Lumino
  • Submit PR that resolves active state versus focus state
  • Maybe: try to get Phosphor author to look at PR
  • Merge PR
@trallard trallard added area: codebase 💻 Item related to codebase and software development work area: WCAG compliance ♿️ This item related to WCAG standards and their compliance labels Jun 29, 2023
@trallard trallard moved this from Todo 📬 to PR opened 📥 in Jupyter a11y CZI grant 🚀 Jul 27, 2023
@gabalafou
Copy link
Contributor Author

Note, the one part of the acceptance criteria that jupyterlab/lumino#607 does not meet is:

Pressing escape does not lose focus to the document body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: codebase 💻 Item related to codebase and software development work area: WCAG compliance ♿️ This item related to WCAG standards and their compliance
Projects
Status: PR opened 📥
Development

No branches or pull requests

2 participants