Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSL sends a bunch of login plugin packets all at once instead of doing proper handshakes #338

Open
woodiertexas opened this issue Aug 16, 2023 · 2 comments

Comments

@woodiertexas
Copy link
Contributor

Apparently QSL inherits the ServerLoginConnectionEvents.QUERY_START stuff from FAPI. What it should be doing is sending requests and responses one at a time instead of all at once.

@LambdAurora
Copy link
Contributor

Any reason why this is an issue?

@TheGlitch76
Copy link
Member

So the problem that's being referenced here is in a blanketcon-specific optimization where they use zstd compression on the networking stack. With the current behavior, the server can prepare uncompressed packets before the client's reply is handled. This means the client expects zstd-compressed packets and receives the uncompressed packets instead.

In other words,
The QSL networking API is based on the assumption that login query packets do not have side-effects. Is that a reasonable assumption, (and the blanketcon usecase a one-in-a-million exception), or should we change the QSL networking API to send and handle login query packets one at a time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants