Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated code in chat_llm and chat_llm_service #3213

Closed
jacopo-chevallard opened this issue Sep 17, 2024 — with Linear · 1 comment
Closed

Remove duplicated code in chat_llm and chat_llm_service #3213

jacopo-chevallard opened this issue Sep 17, 2024 — with Linear · 1 comment
Assignees
@jacopo-chevallard
Labels
area: backend Related to backend functionality or under the /backend directory

Comments

@jacopo-chevallard Linear
Copy link
Collaborator

Currently, backend/core/quivr_core/chat_llm.py and backend/api/quivr_api/modules/chat_llm_service/chat_llm_service.py largely duplicate the code in brain.py and rag_service.py . With the newly introduced workflows and yaml configuration file, we can simply create (at run-time) a different workflow which only contains the filter_history and generate steps, thus removing from the codebase these redundant classes
@linear Linear
Copy link

linear bot commented Sep 17, 2024

CORE-203 Remove duplicated code in chat_llm and chat_llm_service

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Sep 17, 2024
@jacopo-chevallard jacopo-chevallard self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacopo-chevallard jacopo-chevallard

Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacopo-chevallard