Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: library has version 7.0.0.0 in 6.0.0 tarball and 2.8.0.37 in 6.0.x branch #157

Open
imwints opened this issue Feb 12, 2024 · 3 comments

Comments

@imwints
Copy link

imwints commented Feb 12, 2024

Problem Description

We want to detect the installed rocm version with version.major, but on ArchLinux, which installs from the 6.0.0 tarball, the reported major version is 7. I checked the 6.0.x branch and there the major version is 2.

Also in CMakeLists.txt, in both the tarball (6.0.0) and the git tag (6.0.x) the get_package_version_number passes "7.0.0" as the default version for parsing (which makes little sense to me, this is not version 7 but 6 [and how on earth does the get_package_version_number produces 2.8.0.37???]).

Operating System

Irrelevant

CPU

Irrelevant

GPU

AMD Radeon VII

ROCm Version

ROCm 6.0.0

ROCm Component

rocm_smi_lib

Steps to Reproduce

git checkout rocm-6.0.x
cmake -B build -G Ninja
The configure step will already print the version number

Do the same for the 6.0.0 release tarball

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@imwints
Copy link
Author

imwints commented Feb 12, 2024

This doesn't happen when you do a shallow clone with git clone --depth 1 ..., then the version is 7.0.0.0 again instead of 2.8.0.37 (and the configure output states that git rev-parse failed)

@ppanchad-amd
Copy link

@imwints Apologies for the lack of response. Can you please check if your issue still exist with the latest ROC 6.2? If not, please close the ticket. Thanks!

@imwints
Copy link
Author

imwints commented Aug 7, 2024

From git (rocm-6.2.x):

Package version: 7.2.0.4-local-build-0-5ac86f6

From latest tarball:

Package version: 7.3.0.0-local-build-0-unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants