[Refactoring]: Server initialization

[thelsing]

Describe the problem

Currently server initialization is a mess. We start a server and immediately try to connect to it. If the server is already running the first step fails, but we still try to connect to the server. If we failed the connection because the server is already running we get confusion messages ("Player already exists" if we used the same name the existing server uses") or even the "Please notify your GM of your PIN .." because we connected to some server via webrtc.

I often see the "Failed to start personal server" message when something went wrong with server start.

The huge catch bloc for many different exceptions in the START_SERVER action isn't nice too. I'd like to remove that.

The improvement you'd like to see

IMO we need some clean chain of events with onComplete and onError handlers. We already have something similar for establishing client connections. The whole connection establishment should probably be refactored to use CompleteableFuture.

Expected Benefits

Clean way to init server, better error handling, code that is easier to understand.

Additional Context

No response

[thelsing]

We should also get rid of the "please wait until map reloads" and block the screen until server start and connection to it is done.

[FullBleed]

We should also get rid of the "please wait until map reloads" and block the screen until server start and connection to it is done.

Definitely. Has always been a bugaboo.