Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Token Movement overlay is off on a hex grid #3838

Closed
Piglit opened this issue Feb 16, 2023 · 2 comments · Fixed by #3839
Closed

[Bug]: Token Movement overlay is off on a hex grid #3838

Piglit opened this issue Feb 16, 2023 · 2 comments · Fixed by #3839
Assignees
Labels

Comments

@Piglit
Copy link

Piglit commented Feb 16, 2023

Describe the Bug

The movement-highlight of the grid tiles is a half tile off when dragging a token around on a hex-grid.
See Screenshot.
It starts to occure on new maps as soon as the server is started. When the server is stopped it still occures on the used map, but not on new maps created after the server was stopped.
When a new map is created on a running server, the bug does not occure until the server is stopped; but immediately after stopping the server.

To Reproduce

  1. Create a new Map with a hex grid (the bug occures on both orientations)
  2. Create a Token
  3. Drag the Token around with mouse or keyboard. Token position, blue line and grey highlighted tiles are displayed correctly now.
  4. Start Server
  5. Drag the Token around with mouse or keyboard. Token position and blue line are still correct, but the path highlight is half a tile off to the right.
  6. Stop the server
  7. Drag the Token around with mouse or keyboard. The path highlight is still half a tile off to the right.

Expected Behaviour

I would expect the highlighted tiles to match the grid.

Screenshots

Screenshot (696)

MapTool Info

Version: 1.12.2, Installed via msi-Installer, Updated from 1.12.1

Desktop

Windows 10

Additional Context

No response

@Piglit Piglit added the bug label Feb 16, 2023
@Phergus
Copy link
Contributor

Phergus commented Feb 16, 2023

This issue wasn't present in 1.11.5. It shows up in 1.12.1.

After doing an Adjust Grid but not changing anything the behavior is fixed.

@kwvanderlinde
Copy link
Collaborator

Bisected to 60a2de6. Problem is a simple typo of setY() instead of setX() when mapping Dimension to protobuf. Using "Adjust Grid" fixes it by setting the local value through non-protobuf means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants