Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Let the DM know when a player finishes loading assets #3890

Closed
sauliuskarmanovas opened this issue Mar 31, 2023 · 2 comments · Fixed by #3894
Closed

[Feature]: Let the DM know when a player finishes loading assets #3890

sauliuskarmanovas opened this issue Mar 31, 2023 · 2 comments · Fixed by #3894
Assignees
Labels
feature Adding functionality that adds value

Comments

@sauliuskarmanovas
Copy link
Contributor

Feature Request

Info for the DM know when the player is ready to play.

The Solution you'd like

A simple message in GMs chat would be enough. Maybe some time down the road actual ClientMessages with handlers and events to show in a nice separate panel what zone each player is in and their loading progress.

Alternatives that you've considered.

Asking several times every player if they are in yet every time the map changes 🤢

Additional Context

No response

@sauliuskarmanovas sauliuskarmanovas added the feature Adding functionality that adds value label Mar 31, 2023
@sauliuskarmanovas
Copy link
Contributor Author

sauliuskarmanovas commented Mar 31, 2023

Something like

if (MapTool.getConnection() != null) {
  String mesg =
      MessageUtil.getFormattedSystemMsg(
          I18N.getText(
              "msg.info.playerFinishedLoadingZone",
              MapTool.getPlayer().getName(),
              zone.getDisplayName()));
              
  TextMessage msg = TextMessage.gm(null, mesg);
  MapTool.addMessage(msg);
}

with {0} has finsihed loading into zone {1}. as a message.
Right here

if (isLoaded) {
// Notify the token tree that it should update
MapTool.getFrame().updateTokenTree();
}

@kwvanderlinde
Copy link
Collaborator

Tested. The connection indicator shows the number of connected clients (including the one running the server). It typically shows the number of loaded clients as well, though the number can cycle a lot during loading. Interestingly, when I loaded a large campaign, it sometimes showed 0 loaded clients, even after the server client has already loaded. Very minor though, can be addressed separately if it turns out to be a real problem.

It's not clear to me whether the connection indicator gives the expected information in the context of this FR. It does not show the number of clients on the GM's map, rather it shows the clients that have their own current map loaded. But this seems good to me as not all games require players to be on the same map, and the Connections window can be used for more detailed information if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants