Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App redesign - change to leafgl and rhino #2

Closed
38 of 43 tasks
RWParsons opened this issue Jun 5, 2024 · 2 comments
Closed
38 of 43 tasks

App redesign - change to leafgl and rhino #2

RWParsons opened this issue Jun 5, 2024 · 2 comments

Comments

@RWParsons
Copy link
Owner

RWParsons commented Jun 5, 2024

To expand on the following point in Jace's list:

[ ] BIG ONE: move iTRAQI_app into a subdirectory of iTRAQI-anlayses (this repo) and make it as a rhino app with the same renv. It's much too hard to maintain across two repositories as they share a lot of the same data. Need to move to rhino app since it's impossible to look at the old app as it is much too large.

  • use rhino framework
  • use outputs from analyses pipeline
  • recreate maps tab using leafgl
    • layer selection
      • polygons 989275f
      • make transition between displayed shapes faster by adding new layer before a show and then hide/remove old layer bf1a1e9
      • popups on polygons be8bdd8
      • rasters 63967ad
      • add legends f91cdc6
    • filters dc0d8d7
    • complete base map with RSQ/aero/centre icons 99f3e95
    • interactive plot
      • base plot that's reactive to 'show plot' checkbox 1365e9d
      • visibility of points dependent on filters ae4193b
      • colour scales on plot dependent on layer selected (acute/rehab/index) 74510c1
      • hide 'show_plot' button if selected layer is not a polygon 72be097
      • implement brush and click interactivity to the plot/map b524bd7
    • time-to-care prediction from map click
      • make new marker with predicted acute/rehab time in popup cb31b6c
      • automatically trigger popup to appear shortly after marker is added a63d43c
      • remove prediction marker when marker is clicked db713fb
    • add spinner/waiter with fun fact(oid)s eddc5d9
  • recreate tour tab using leafgl
    • create structure for progressing/regressing through tour 3abeaa5
    • associated card content with the tour stage 13b07ff
    • associated map content with the tour stage c0d67d3
    • incorporate map view/panning with tour stages 42ed505
  • recreate info tab 1313335
  • recreate downloads tab bf09223
  • replace rhino logo with an iTRAQI logo 25b2493

misc. features/changes/bug fixes

  • update marker popup text from within pipeline 179eaec
  • check that the user hasn't changed tour tab before the delayed map pan occurs fb83a48
  • add linters https://www.appsilon.com/post/box-linters-in-rhino-1-8-0 fd6ea0f
  • output all app inputs straight into app directories to replace the update-data.R script a206670
  • fix the (lack of) appearance of acute/rehab raster layer on tour da65cdd
  • need to be able to change the map popups on shapes to be labels so that the map_click event can trigger the creation of a prediction marker and it's popup, not the display of the shape popup. Following the recent developments on leafgl for this here: Label argument not working r-spatial/leafgl#78
    • wait for the above PR to get accepted and merged into leafgl.
    • change what are currently polygon popups to be labels (hover, rather than click to show)
    • adjust the z-index of markers/labels/layers etc so that order is correct and center markers don't appear above polygon popups/labels
    • ensure that prediction markers work as expected and aren't hidden behind polygon labels
  • avoid rsq and qas markers appearing on map load when not default tab 974b29a
  • put markers at higher z-index than polygons ae04bc7
  • produce empty map without error when filter removes all polygons from map 9b03e02
@RWParsons RWParsons mentioned this issue Jun 6, 2024
26 tasks
@jacellewarren
Copy link

Thanks for this list too, Rex!

@RWParsons
Copy link
Owner Author

Closing this issue as it seems that the changes in leafgl are taking ages to happen and mapgl looks like a potentially better option. See #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants