Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create single API/base class for all topic models #938

Closed
devashishd12 opened this issue Oct 12, 2016 · 2 comments · Fixed by #946
Closed

Create single API/base class for all topic models #938

devashishd12 opened this issue Oct 12, 2016 · 2 comments · Fixed by #946
Labels
difficulty medium Medium issue: required good gensim understanding & python skills

Comments

@devashishd12
Copy link
Contributor

As discussed on gitter, it would be nice to have a single API/base class which can be extended by all topic models. This will include common functions such as print_topic() which are needed by all models. eg. show_topic() is not present in HdpModel currently and adding this function would incur code duplication.
@tmylk tmylk added the difficulty medium Medium issue: required good gensim understanding & python skills label Oct 12, 2016
@bhargavvader
Copy link
Contributor

Also related - #945. :)
Any ideas on how to start doing this?

@bhargavvader bhargavvader mentioned this issue Oct 12, 2016
Closed
@markroxor markroxor mentioned this issue Oct 13, 2016
Merged
@markroxor
Copy link
Contributor

markroxor commented Oct 13, 2016 •
edited
Loading

I've submitted a pull request #946 for a unified base class. Not sure if this you are actually looking for but review and let me know if I'm going in the right direction so that I can proceed further with this. thanks

tmylk added a commit that referenced this issue Oct 18, 2016
@tmylk
Merge pull request #946 from markroxor/singleapi
bf7c0ed 
Create unified base class for all topic models, #938
@ghost ghost mentioned this issue Jun 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty medium Medium issue: required good gensim understanding & python skills
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creating unified base class for all topic models, #938 markroxor/gensim
4 participants
@tmylk @bhargavvader @devashishd12 @markroxor