[WIP] Replaced logger.warn by logger.warning
#1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
reviewed
Apr 30, 2017
gensim/corpora/sharded_corpus.py
Outdated
| @@ -264,7 +264,7 @@ def init_shards(self, output_prefix, corpus, shardsize=4096, dtype=_default_dtyp | |||
| logger.info('Deriving dataset dimension from corpus: ' | |||
| '{0}'.format(proposed_dim)) | |||
| else: | |||
| logger.warn('Dataset dimension derived from input corpus diffe' | |||
| logger.warning('Dataset dimension derived from input corpus diffe' | |||
There was a problem hiding this comment.
Unrelated, but could you please replace the vertical indent with hanging indent in these warnings? This is a great example of why we don't want vertical indent -- harder to maintain.
There was a problem hiding this comment.
Sure! I'll replace vertical indent with hanging indent for all the warnings here.
chinmayapancholi13
changed the title
logger.warn by logger.warninglogger.warn by logger.warning
|
Thanks for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
logger.warntologger.warningin the code sincelogging.warnhas been deprecated since Python 3.3 and it is advisable to uselogging.warning(Reference).Relevant Google mailing list discussion here.