Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc2vec __init__ documentation #1379

Merged
merged 1 commit into from
Jun 4, 2017
Merged

Conversation

jstol
Copy link
Contributor

@jstol jstol commented Jun 1, 2017

Fixed descriptions of various arguments passed from Doc2Vec.__init__ method up to the parent Word2Vec.__init__ method.

  • alpha: says will drop to 0 as training progressed, but should say min_alpha.
  • hs: is said to be 1 by default, but is 0 by default (and also mentions "hierarchical sampling", rather than "hierarchical softmax").
  • negative: doesn't mention that the default is 5.

Fixed descriptions of various arguments passed up to parent Word2Vec __init__ method.
@gojomo
Copy link
Collaborator

gojomo commented Jun 1, 2017

+1

@menshikh-iv
Copy link
Contributor

Thank you @jstol 👍

@menshikh-iv menshikh-iv merged commit 214fff7 into piskvorky:develop Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants