Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note about training mode in 'partial_fit' #1382

Merged
merged 5 commits into from
Jun 5, 2017

Conversation

chinmayapancholi13
Copy link
Contributor

This PR adds a note about the mode used for training in the partial_fit function in the sklearn wrapper for LDA model.

@@ -126,6 +126,8 @@ def get_topic_dist(self, bow, minimum_probability=None, minimum_phi_value=None,
def partial_fit(self, X):
"""
Train model over X.
By default, 'online' mode is used for training the LDA model.
Configure `passes` and `update_every` params at init to choose the mode among 'online', 'mini-batch', 'batch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add explicit values to use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the mode names and also added explicit values to use for each mode.

@@ -126,6 +126,11 @@ def get_topic_dist(self, bow, minimum_probability=None, minimum_phi_value=None,
def partial_fit(self, X):
"""
Train model over X.
By default, 'online (single-pass)' mode is used for training the LDA model.
Configure `passes` and `update_every` params at init to choose the mode among :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove spaces before : everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Doing it right away.

@menshikh-iv menshikh-iv merged commit eefca37 into piskvorky:develop Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants