Remove test_req installations #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menshikh-iv should I add tensorflow to test_env in setup.py? |
|
@ibrahimsharaf Yes, please add tensorflow to test_env |
menshikh-iv
reviewed
Jun 8, 2017
appveyor.yml
Outdated
| @@ -66,8 +66,6 @@ test_script: | |||
| # installed library. | |||
| - "mkdir empty_folder" | |||
| - "cd empty_folder" | |||
| - "pip install pyemd testfixtures unittest2 sklearn Morfessor==2.0.2a4" | |||
There was a problem hiding this comment.
Please revert this, because these dependencies will not be installed
|
@menshikh-iv do we have to specify the version? won't it get the latest one? |
|
@ibrahimsharaf It's strange problem with installing dependencies, I will try to solve it. |
|
@menshikh-iv I'll ping you if I found a solution. |
|
@menshikh-iv thoughts? |
|
Thank you @ibrahimsharaf, now all ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue (#1393)