Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Google Tag Manager (TGM) #1556

Merged
merged 3 commits into from
Sep 1, 2017
Merged

Conversation

yardos
Copy link
Contributor

@yardos yardos commented Aug 31, 2017

  • removed old Google Analytics code (Urchin)
  • added code for Google Tag Manager - one in head, the other in body

... continued from #1554 .

- removed old Google Analytics code
- added two snippets for Google Tag Manager (GTM), one in head, the other in body
- removed old Google Analytics code (Urchin)
- added code for Google Tag Manager - one in head, the other in body
@piskvorky piskvorky changed the title Gtm jd Implement the Google Tag Manager (TGM) Aug 31, 2017
@menshikh-iv
Copy link
Contributor

Congratz with your first PR @yardos👍

@menshikh-iv menshikh-iv merged commit 26b285e into piskvorky:develop Sep 1, 2017
@piskvorky
Copy link
Owner

piskvorky commented Sep 1, 2017

@yardos do you want me to regenerate http://radimrehurek.com/dostal_gensim/ again? Or is this enough, can I delete that site? (I don't want to keep it for long, search robots don't like duplicate content -- I just edited robots.txt)

The main gensim page http://radimrehurek.com/gensim/ will be regenerated with the next gensim release (~next week IIRC, is that correct @menshikh-iv ?).

@yardos
Copy link
Contributor Author

yardos commented Sep 1, 2017

@piskvorky yes, please regenerate http://radimrehurek.com/dostal_gensim/ - I can test the GTM implementation there at the mean time

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Sep 1, 2017

@piskvorky ~next 2 weeks.

@piskvorky
Copy link
Owner

piskvorky commented Sep 1, 2017

@yardos there were no new changes, so http://radimrehurek.com/dostal_gensim/ should be up-to-date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants