Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Keyedvectors.get_embedding_layer #1558

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Fix Keyedvectors.get_embedding_layer #1558

merged 1 commit into from
Sep 1, 2017

Conversation

zsef123
Copy link
Contributor

@zsef123 zsef123 commented Sep 1, 2017

Issue #1557

When moved get_embedding_layer function to keyedvectors ( commit b7c3e2d )

train_embeddings is missing.

So I add argument trainable on Embedding

@menshikh-iv
Copy link
Contributor

Thank you @zsef123, nice first contribution 🥇

@menshikh-iv menshikh-iv merged commit 3d2227d into piskvorky:develop Sep 1, 2017
@menshikh-iv menshikh-iv mentioned this pull request Sep 1, 2017
Closed
@zsef123 zsef123 deleted the fix-KeyedVectors branch September 4, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsef123 @menshikh-iv