Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation #2157

Merged
merged 4 commits into from
Aug 20, 2018
Merged

Conversation

KenjiOhtsuka
Copy link
Contributor

Fixed misspelling.

/dics/src/changes_080.rst contains the word "mmapped". Is it the misspelling of "mapped"? If so, I'll fix it too.

Large matrices (numpy/scipy.sparse, in LsiModel, Similarity etc.) are now mmapped to/from disk when doing save/load. The cPickle approach used previously was too buggy <http://groups.google.com/group/gensim/browse_thread/thread/3c4c6c0f76c5938c#>_ and slow <http://dieter.plaetinck.be/poor_mans_pickle_implementations_benchmark.html>_.

@piskvorky
Copy link
Owner

Thanks for the typo fix.

mmap is not a misspelling, but if you see it used somewhere prominent, feel free to hyperlink the term to https://en.wikipedia.org/wiki/Mmap (in case it helps others).

@menshikh-iv menshikh-iv changed the title fix spelling: practicitoners -> practitioners Fix typo in documentation Aug 20, 2018
@menshikh-iv
Copy link
Contributor

Thanks @KenjiOhtsuka, congratz with first contribution 🥇

@menshikh-iv menshikh-iv merged commit 46124f4 into piskvorky:develop Aug 20, 2018
@piskvorky
Copy link
Owner

Eh, changing the release notes of Gensim 0.8.0 (> 7 years ago) was not really necessary :)

I meant hyperlinking mmap in actual documentation -- where it matters, where people can see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants