Fix poincate viz incompatibility with plotly>=3.0.0
#2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menshikh-iv
suggested changes
Oct 15, 2018
gensim/models/phrases.py
Outdated
| @@ -805,7 +805,7 @@ def __init__(self, phrases_model): | |||
| for bigram, score in phrases_model.export_phrases(corpus, self.delimiter, as_tuples=True): | |||
| if bigram in self.phrasegrams: | |||
| logger.info('Phraser repeat %s', bigram) | |||
| self.phrasegrams[bigram] = (phrases_model.vocab[self.delimiter.join(bigram)], score) | |||
| self.phrasegrams[bigram] = score | |||
There was a problem hiding this comment.
Not relevant to the original issue, please revert all phrases.py file
| @@ -59,7 +59,7 @@ def poincare_2d_visualization(model, tree, figure_title, num_nodes=50, show_node | |||
| mode='markers', | |||
| marker=dict(color='rgb(30, 100, 200)'), | |||
| text=node_labels, | |||
| textposition='bottom' | |||
| textposition='bottom center' | |||
There was a problem hiding this comment.
What's about older plotly version? I think PR changes works only for new. This should be compatible with new & old plotly.
There was a problem hiding this comment.
Checked - it works for 2.7.0 too, great!
menshikh-iv
approved these changes
Jan 9, 2019
menshikh-iv
changed the title
plotly>=3.0.0
|
Thanks for contribution @jenishah 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2123.