Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keep_n behavior for Dictionary.filter_extremes #2232

Merged
merged 3 commits into from
Dec 13, 2018

Conversation

johann-petrak
Copy link
Contributor

@johann-petrak johann-petrak commented Oct 15, 2018

If keep_tokens are specified, this fixes the problem by using a lambda for
sorting which returns a fake document frequence equal to the number of documents
for all tokens in the keep list.

Fix #2230

If keep_tokens are specified, this fixes the problem by using a lambda for
sorting which returns a fake document frequence equal to the number of documents
for all tokens in the keep list.
@menshikh-iv menshikh-iv mentioned this pull request Oct 15, 2018
@menshikh-iv menshikh-iv changed the title Proper commit for fixing issue #2230 Fix keep_n behavior for Dictionary.filter_extremes Oct 15, 2018
@menshikh-iv
Copy link
Contributor

Thanks for PR @johann-petrak, can you

  1. Add test for this case (to avoid regression in future)
  2. Merge latest develop to your branch (outdated base branch is an reason of failed CircleCI)

For last you need

@johann-petrak
Copy link
Contributor Author

Thanks! Sorry, still not too familiar with pull requests in general and gensim in particular.
So - the development branch is the one which should be used to get the latest development head and for testing and fixing issues?

@johann-petrak
Copy link
Contributor Author

I think this should be ready to get merged, please let me know if anything should be still missing.

@johann-petrak
Copy link
Contributor Author

Sorry to bump this, but I did think I did everything necessary, is there still anything missing from my side?

@piskvorky
Copy link
Owner

piskvorky commented Nov 10, 2018

@johann-petrak thanks a lot! We'll get to open source in a few weeks again (swamped now). Is merging this PR urgent for you?

@johann-petrak
Copy link
Contributor Author

Not really urgent just wondered if there might still something missing.

@menshikh-iv
Copy link
Contributor

Sorry for waiting, thanks for PR @johann-petrak 👍

@menshikh-iv menshikh-iv merged commit 6fb086f into piskvorky:develop Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The keep_tokens parameter for Dictionary.filter_extremes does not work properly
3 participants