-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keep_n
behavior for Dictionary.filter_extremes
#2232
Conversation
If keep_tokens are specified, this fixes the problem by using a lambda for sorting which returns a fake document frequence equal to the number of documents for all tokens in the keep list.
keep_n
behavior for Dictionary.filter_extremes
Thanks for PR @johann-petrak, can you
For last you need
|
Thanks! Sorry, still not too familiar with pull requests in general and gensim in particular. |
I think this should be ready to get merged, please let me know if anything should be still missing. |
Sorry to bump this, but I did think I did everything necessary, is there still anything missing from my side? |
@johann-petrak thanks a lot! We'll get to open source in a few weeks again (swamped now). Is merging this PR urgent for you? |
Not really urgent just wondered if there might still something missing. |
Sorry for waiting, thanks for PR @johann-petrak 👍 |
If keep_tokens are specified, this fixes the problem by using a lambda for
sorting which returns a fake document frequence equal to the number of documents
for all tokens in the keep list.
Fix #2230