Refactor line2doc methods of LowCorpus and MalletCorpus
#2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horpto
force-pushed
the
nonoptimal-lowcorpora
branch
2 times, most recently
from
5ba87a5
to
ef27d11
Compare
horpto
force-pushed
the
nonoptimal-lowcorpora
branch
from
ef27d11
to
5f163f4
Compare
horpto
force-pushed
the
nonoptimal-lowcorpora
branch
from
5f163f4
to
fcc9bc1
Compare
menshikh-iv
reviewed
Dec 14, 2018
| docid, doclang, words = splited_line[0], splited_line[1], splited_line[2:] | ||
| split_line = utils.to_unicode(line).strip().split(None, 2) | ||
| docid, doclang = split_line[0], split_line[1] | ||
| words = split_line[2] if len(split_line) >= 3 else '' |
There was a problem hiding this comment.
why >=, not an =? I asked because "If maxsplit is given, at most maxsplit splits are done".
There was a problem hiding this comment.
Just a habbit to write more flexible code on the case of future changes.
menshikh-iv
changed the title
horpto
changed the title
menshikh-iv
changed the title
line2doc method of LowCorpus and MalletCorpus
menshikh-iv
changed the title
line2doc method of LowCorpus and MalletCorpusline2doc methods of LowCorpus and MalletCorpus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.