Improve filter_extremes methods in Dictionary and HashDictionary
#2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
horpto
commented
Dec 19, 2018
•
horpto
commented
- use search by set instead of list
- refine default value of dict.get() method
- inplace sort
- use search by set instead of list - refine default value of dict.get() method - inplace sort
horpto
force-pushed
the
dictionary-keep_ids
branch
from
19b3ba1
to
f0d0621
Compare
menshikh-iv
reviewed
Dec 19, 2018
| ) | ||
| good_ids = sorted(good_ids, key=lambda x: self.num_docs if x in keep_ids else self.dfs.get(x), reverse=True) | ||
| ] | ||
| good_ids.sort(key=lambda x: self.num_docs if x in keep_ids else self.dfs.get(x, 0), reverse=True) |
There was a problem hiding this comment.
why sorted(generator) -> list.sort()? Is this save memory or what's a difference?
There was a problem hiding this comment.
It saves me from linter XD
No, it does not save memory https://github.com/python/cpython/blob/master/Python/bltinmodule.c#L2201
menshikh-iv
changed the title
filter_extremes methods in Dictionary and HashDictionary
|
Thanks @horpto ⭐ |
|
Awesome! These are the kind of deep and small but important fixes that help us so much. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.