Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new convention of delimiting instance params in str function #3251

Merged
merged 5 commits into from
Oct 24, 2021
Merged

Apply new convention of delimiting instance params in str function #3251

merged 5 commits into from
Oct 24, 2021

Conversation

menshikh-iv
Copy link
Contributor

Fix #2890

piskvorky
piskvorky approved these changes Oct 23, 2021
View reviewed changes
Copy link
Owner

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@mpenkov mpenkov merged commit 9ca0fe1 into piskvorky:develop Oct 24, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented Oct 24, 2021

Merged. Thank you @menshikh-iv !!

@menshikh-iv menshikh-iv deleted the fix-class-param-style branch October 24, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov left review comments

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply new convention of delimiting instance params in str function
3 participants
@menshikh-iv @mpenkov @piskvorky