Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov to gensim repo #3252

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Conversation

menshikh-iv
Copy link
Contributor

@menshikh-iv menshikh-iv commented Oct 23, 2021

Fix #2002

CC @mpenkov, I need you to follow instruction from https://docs.codecov.com/docs#basic-usage to have an upload token available in github actions (or just integrations with github repo)

What's need to add after token will be available:

@mpenkov
Copy link
Collaborator

mpenkov commented Oct 24, 2021

Waiting for @piskvorky to approve codecov access to the gensim repo (he's the repo owner). I think codecov has sent the request by email.

@piskvorky
Copy link
Owner

piskvorky commented Oct 24, 2021

It has. But the app is asking for permissions to access private data, which I cannot do:

Screenshot - 2021-10-24T101749 223

@menshikh-iv
Copy link
Contributor Author

@piskvorky can you please try to add codecov as app form here https://github.com/marketplace/codecov/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW4xNg==

In that case, you should have a way to select a repo

@piskvorky
Copy link
Owner

Thanks, done: I "installed" that app into 4 public repos: Gensim, smart-open, sqlitedict and bounter.

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@5bec277). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3252   +/-   ##
==========================================
  Coverage           ?   78.88%           
==========================================
  Files              ?       68           
  Lines              ?    11772           
  Branches           ?        0           
==========================================
  Hits               ?     9286           
  Misses             ?     2486           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bec277...42e641f. Read the comment docs.

@menshikh-iv menshikh-iv changed the title WIP: Add Codecov to gensim repo Add Codecov to gensim repo Oct 24, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented Oct 24, 2021

Good work @menshikh-iv . Thank you!!

@mpenkov mpenkov merged commit d2341aa into piskvorky:develop Oct 24, 2021
@menshikh-iv menshikh-iv deleted the add-codecov branch October 24, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use coveralls
3 participants