-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify runtime expectations #3381
Conversation
# so even this tiny training will take minutes rather than seconds. (And, in that | ||
# case, you should also notice a warning in the logging letting you know there's | ||
# something worth fixing.) So, be sure your installation uses the BLAS-optimized | ||
# Gensim if you value your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A concrete set of instructions for how to actually perform such check would be helpful here. E.g. through the FAST_VERSION
attribute.
I'd also personally drop all the brackets, but I realize that's your writing style :)
Thanks! I'm also not sure what the "canonical" vs generated paths are, or Sphinx |
Code under auto_examples is essentially a copy. We do keep it under version control (reasons below), but you shouldn't have to change it manually yourself. Instead, rebuild the gallery, and Sphinx will update those files for you. You can then add them to the PR. The reason why we keep these duplicate files under version control is to keep Sphinx happy. If those files are missing, then Sphinx will attempt to rebuild the gallery from the source files, by running each of them individually. This takes time (hours). We want to avoid that, because we want our documentation to build relatively quickly from a fresh clone of the repo. |
…s_gojomo-doc2vec-lee-runtime
@gojomo @piskvorky Our CI now shows you what needs to be done:
This has been around for a while, but other linting issues with the PR were masking it. |
Motivated by discussion thread: https://groups.google.com/g/gensim/c/ZnuJkxWT6ps/m/x5pXQgU8AAAJ
Related: it seems there's an exact duplicate of this file in project-path
/gensim/docs/src/**auto_examples**/tutorials
. I think that (& sibling plain.py
files there) are just automatic copies of these canonical versions, so I haven't applied the change there. (And perhaps, even though we want to commit the other sphinx-build outputs there, we don't want the duplicate.py
sources there?)