Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify runtime expectations #3381

Merged
merged 4 commits into from
Dec 7, 2022
Merged

clarify runtime expectations #3381

merged 4 commits into from
Dec 7, 2022

Conversation

gojomo
Copy link
Collaborator

@gojomo gojomo commented Aug 17, 2022

Motivated by discussion thread: https://groups.google.com/g/gensim/c/ZnuJkxWT6ps/m/x5pXQgU8AAAJ

Related: it seems there's an exact duplicate of this file in project-path /gensim/docs/src/**auto_examples**/tutorials. I think that (& sibling plain .py files there) are just automatic copies of these canonical versions, so I haven't applied the change there. (And perhaps, even though we want to commit the other sphinx-build outputs there, we don't want the duplicate .py sources there?)

# so even this tiny training will take minutes rather than seconds. (And, in that
# case, you should also notice a warning in the logging letting you know there's
# something worth fixing.) So, be sure your installation uses the BLAS-optimized
# Gensim if you value your time.
Copy link
Owner

@piskvorky piskvorky Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A concrete set of instructions for how to actually perform such check would be helpful here. E.g. through the FAST_VERSION attribute.

I'd also personally drop all the brackets, but I realize that's your writing style :)

@piskvorky
Copy link
Owner

piskvorky commented Aug 17, 2022

Thanks! I'm also not sure what the "canonical" vs generated paths are, or Sphinx *.py duplication, deferring to @mpenkov .

@piskvorky piskvorky added this to the Next release milestone Aug 17, 2022
@mpenkov
Copy link
Collaborator

mpenkov commented Aug 21, 2022

Code under auto_examples is essentially a copy. We do keep it under version control (reasons below), but you shouldn't have to change it manually yourself. Instead, rebuild the gallery, and Sphinx will update those files for you. You can then add them to the PR.

The reason why we keep these duplicate files under version control is to keep Sphinx happy. If those files are missing, then Sphinx will attempt to rebuild the gallery from the source files, by running each of them individually. This takes time (hours). We want to avoid that, because we want our documentation to build relatively quickly from a fresh clone of the repo.

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 22, 2022

@gojomo @piskvorky Our CI now shows you what needs to be done:

The gallery cache appears stale.

Rebuild the documentation using the following commands from the gensim root subdirectory:

    pip install -e .[docs]
    make -C docs/src html

and then run `git add docs/src/auto_examples` to update the cache.

Stale files: ['docs/src/auto_examples/tutorials/run_doc2vec_lee.py']

This has been around for a while, but other linting issues with the PR were masking it.

@mpenkov mpenkov added the documentation Current issue related to documentation label Dec 7, 2022
@mpenkov mpenkov merged commit 68fdbf9 into develop Dec 7, 2022
@mpenkov mpenkov deleted the gojomo-doc2vec-lee-runtime branch December 7, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Current issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants