Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependency, handle ImportError #3447

Merged
merged 1 commit into from
Mar 7, 2023
Merged

remove unused dependency, handle ImportError #3447

merged 1 commit into from
Mar 7, 2023

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Mar 3, 2023

  1. Get rid of FuzzyTM import (it's completely unnecessary)
  2. Delay import of pyfume until it's actually used, and then provide instructions for installing it

I also got rid of the flsamodel extra from setup.py, because it's not necessary to introduce another level of indirection here.

Bandaid hot-fix PR until #3437 is properly resolved.

@mpenkov mpenkov requested a review from piskvorky March 3, 2023 10:23
@mpenkov mpenkov added this to the Next release milestone Mar 3, 2023
@danieldaeschle
Copy link

This is needed heavily for us! FuzzyTM brings some GPL licensed code which we must avoid. Please merge this asap and create a new release. That would be helpful for us!

@mpenkov mpenkov merged commit cfb1a62 into develop Mar 7, 2023
@mpenkov mpenkov deleted the hotfix branch March 7, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants