Introduce new prop onLoad
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ReactGoogleCharts.tsx # src/components/GoogleChartLoader.tsx
|
@rakannimer hi. any chance for this PR to be reviewed/merged? |
rakannimer
approved these changes
Dec 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 49.02% 48.74% -0.29%
==========================================
Files 15 15
Lines 514 517 +3
Branches 117 119 +2
==========================================
Hits 252 252
- Misses 193 194 +1
- Partials 69 71 +2
Continue to review full report at Codecov.
|
|
Looks like some checks are failing, @dangreen will follow up, he's been helping maintain this library. |
dangreen
suggested changes
Dec 14, 2021
|
@newsiberian Hi. Thank you for contribution. Please add test case for |
chore: add test
dangreen
approved these changes
Dec 14, 2021
|
@newsiberian Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I need to load custom map source for Geo Chart (call
google.visualization.GeoChart.setMapSource()). This must be done before the firstdraw()in order to load my custom maps, not default.I found tree ways to do that.
windowGoogleCharts.charts.setOnLoadCallback=>this.onLoad=>this.onSuccess=>this.props.onLoadwindowGoogleCharts.charts.setOnLoadCallback=>this.props.onLoadcomponentDidMount(table) =>this.props.onLoadThe 1st - in fact is not working for my case because my callback is called after first
draw()incomponentDidMount(table).The 3rd is working, but it looks ugly, so I think the second is the best option. It looks clean and it is guaranteed to be called before first
draw().