Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--profile uses wrong prefix to find template.html #567

Open
zopsicle opened this issue Jul 28, 2019 · 2 comments · May be fixed by #608
Open

--profile uses wrong prefix to find template.html #567

zopsicle opened this issue Jul 28, 2019 · 2 comments · May be fixed by #608
Assignees
@zopsicle

Comments

@zopsicle
Copy link

zopsicle commented Jul 28, 2019 •
edited
Loading

This line uses the MoarVM prefix to find template.html, whereas the file is in fact under the NQP prefix:

https://github.com/perl6/nqp/blob/fd8a7e5f9255d062e230cb2774dbf25c3d254127/src/vm/moar/HLL/Backend.nqp#L618

Error when running with --profile:

Could not locate profiler/template.html; should have been at /nix/store/b74nh0lhimgjpifrxclmgw0m55jakdy6-MoarVM-2019.07/share/nqp/lib/profiler/template.html; outputting sql data instead

If MoarVM and NQP are configured using different prefixes then this file cannot be found when running with --profile.

Example script to find template.html when using my MoarVM and NQP prefixes:

moarvmPrefix=/nix/store/b74nh0lhimgjpifrxclmgw0m55jakdy6-MoarVM-2019.07
nqpPrefix=/nix/store/358djk9pmr1f3ia9272vvkysyvzjgx0a-nqp-2019.07
find $moarvmPrefix -name '*.html'
find $nqpPrefix -name '*.html'

Output:

/nix/store/358djk9pmr1f3ia9272vvkysyvzjgx0a-nqp-2019.07/share/nqp/lib/profiler/template.html
@lizmat
Copy link
Contributor

lizmat commented Feb 5, 2020

Is this still an issue?

@zopsicle
Copy link
Author

zopsicle commented Mar 30, 2020 •
edited
Loading

@lizmat Yes, the issue persists in 2020.02.1. I looked into it but there doesn’t yet seem to be a way to retrieve the NQP prefix from Raku code.

I’m not very familiar with NQP yet, but I’ll make a PR soon.

@zopsicle zopsicle self-assigned this Mar 30, 2020
@zopsicle zopsicle linked a pull request Mar 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zopsicle zopsicle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NQP prefix for finding profiler template Raku/nqp
2 participants
@lizmat @zopsicle