New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for multiple formats #50

Open

SaicharanKandukuri opened this issue Oct 20, 2023 · 1 comment

Labels

Member

SaicharanKandukuri commented Oct 20, 2023

Looks like some tar version requires special arguments for different formats. like -z for gzip's --zstd for zstd types

check for file formats and use arguments based on formats

The text was updated successfully, but these errors were encountered:

SaicharanKandukuri added enhancement hacktoberfest labels

SaicharanKandukuri removed the hacktoberfest label

Member Author

SaicharanKandukuri commented Apr 28, 2024

Current progress bar implementation works with pv and tar does not support compression type detection when it receives file from standard input.

fs-manager-udroid/udroid/src/proot-utils/proot-utils.sh

Lines 42 to 44 in bf365c3

    
           pv $file | proot \ 
        
                   --link2symlink \ 
        
                   tar --no-same-owner -xz -C "$path" &> $LOG_FILE

To support multiple compression types there are two solutions.

Add check for compression types.
Use tar checkpoints and checkpoint actions feature to calculate progress and create progress bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment