Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for kafka endpoint configuration #230

Closed
wants to merge 2 commits into from
Closed

add support for kafka endpoint configuration #230

wants to merge 2 commits into from

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Sep 6, 2021

@indam23
Copy link
Contributor Author

indam23 commented Sep 6, 2021

I only realized after adding this that it's not necessary; you can just configure additionalEndpoints for kafka.
#207 (comment)

I'd suggest closing this and the related issue since it's a bit confusing to have a "kafka" section that really only pertains to to the rasa deployment's endpoints entries. We could add a note in the README instead.

tczekajlo
tczekajlo suggested changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion.

Can you bump the chart version and add a changelog entry as well? - https://github.com/RasaHQ/rasa-x-helm/blob/main/charts/rasa-x/Chart.yaml#L42-L45

charts/rasa-x/templates/rasa-config-files-configmap.yaml Show resolved Hide resolved
@tczekajlo
Copy link
Contributor

I only realized after adding this that it's not necessary; you can just configure additionalEndpoints for kafka.
#207 (comment)

I'd suggest closing this and the related issue since it's a bit confusing to have a "kafka" section that really only pertains to to the rasa deployment's endpoints entries. We could add a note in the README instead.

Good point, it can be done by using the rasa helm chart.

@tczekajlo tczekajlo closed this Sep 6, 2021
@HotThoughts HotThoughts deleted the kafka_values branch January 11, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczekajlo tczekajlo tczekajlo requested changes

@desmarchris desmarchris Awaiting requested review from desmarchris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use deployment along with Kafka
2 participants
@indam23 @tczekajlo