Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI due to failed tests in NodeJS v18 #96

Open
mhchia opened this issue Aug 31, 2023 · 0 comments
Open

Fix CI due to failed tests in NodeJS v18 #96

mhchia opened this issue Aug 31, 2023 · 0 comments

Comments

@mhchia
Copy link
Member

mhchia commented Aug 31, 2023

What's wrong?

CI is failing #90 (comment). The weird part is it only fails with NodeJS V18, but it runs correctly on my laptop.

How to fix it?

Since CI works with v16 and tests work well with V18 on my laptop, I think we can revisit it later
This was referenced Aug 31, 2023
Merged
Merged
Merged
@mhchia mhchia changed the title Fix CI due to failed tests Fix CI due to failed tests in NodeJS v18 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhchia