Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[The Next Week] [Typo] Chapter 8.1 "Intance" should be "Instance" #629

Closed
manas96 opened this issue May 31, 2020 · 2 comments
Closed

[The Next Week] [Typo] Chapter 8.1 "Intance" should be "Instance" #629

manas96 opened this issue May 31, 2020 · 2 comments

Comments

@manas96
Copy link
Contributor

manas96 commented May 31, 2020

I would like to make the change. Do I make a PR against dev-minor ?
@trevordblack
Copy link
Collaborator

  1. Make a branch off of dev-minor
  2. Make change
  3. Make PR against dev-minor
  4. Be sure to add the change to the CHANGELIST
  5. Would you like to be added to the acknowledgments section?

If you need help with any of this feel free to ask

@manas96 manas96 mentioned this issue May 31, 2020
Merged
@manas96
Copy link
Contributor Author

manas96 commented May 31, 2020

Done. Yes, I would like to be added to the acknowledgments.

@manas96 manas96 closed this as completed May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trevordblack @manas96