Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book1 Diffuse text is confusing #696

Closed
yig opened this issue Aug 14, 2020 · 1 comment
Closed

Book1 Diffuse text is confusing #696

yig opened this issue Aug 14, 2020 · 1 comment

Comments

@yig
Copy link

yig commented Aug 14, 2020

The text around the correct cos(𝜙) distribution is confusing. Sections 8.6 "An Alternative Diffuse Formulation" and 8.5 "True Lambertian Reflection" both seem to me to be correcting Section 8.1 "A Simple Diffuse Material" by claiming to describe a correct cos(𝜙) distribution. However, the pictures aren't the same, so I must be misunderstanding.

Moreover, in Section 8.6 "True Lambertian Reflection", the text above code listing 37 says, "This is achieved by picking points on the surface of the unit sphere, offset along the surface normal. Picking points on the sphere can be achieved by picking points in the unit ball, and then normalizing those." Based on this, I would have expected code listing 37 to make use of "random_in_unit_sphere()". Instead, it does something else entirely that is not explained. (It generates a z value and an xy-plane angle, and then chooses x and y such that they have the angle and the point is on the unit sphere).

@trevordblack
Copy link
Collaborator

Closing this out with the landing of #1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants