Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand contributors field in DESCRIPTION? #3144

Closed
mattdowle opened this issue Nov 14, 2018 · 1 comment
Closed

Expand contributors field in DESCRIPTION? #3144

mattdowle opened this issue Nov 14, 2018 · 1 comment
Milestone

Comments

@mattdowle
Copy link
Member

This came up in PR #3111.

I don't think there is any limit to the Authors field in DESCRIPTION. So we could have a much longer list of names in there to include even relatively small code contributions. This would be a way to thank and encourage contributions, which the project seeks to attract. The names would still be ordered so the biggest contributors appear first. It might be easier to revise ordering over time, than inclusion or not. I guess contributors like their names to be there as the main thing, but don't mind as much about relative order.

I think I lean towards looking at all past contributions and if they contributed code then add their names. I haven't looked yet but I guess something like about 20 names would be added, including PR#3111.

Trying to be fair to everyone, past and present.

@mattdowle
Copy link
Member Author

mattdowle commented Feb 26, 2019

@oseiskar
@dracodoc
@mllg
@restonslacker
@renkun-ken
@kbroman
@RoyalTS
@DavidArenburg
@ethanbsmith
@fcocquemas
@matthieugomez
@philippechataignon
@DexGroves
@shrektan
@heavywatal
@dpprdan
@fparages
@tdeenes
@MusTheDataGuy
@ayappanec
@jsams
@mtmorgan
@michaelquinn32
@javrucebo

Just to let you know you've been added to data.table's DESCRIPTION as contributor. Thanks to all of you for your contributions! I included everyone who has contributed or fixed code. If I missed anyone, or there are any typos, please let me know.

I excluded ids who have just touched documentation; e.g. typo fixes. Those are valuable and welcome contributions but that would have been 61 names. Excluding those (by manual inspection) reduced 61 down to 36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant